Kaikki raportit
umbrella_displayed raportit
#163015: "Unable to create a tutorial due to missing ID attributes in the HTML"
implemented: Tämä ehdotus on toteutettu
1
Mitä tämä raportti koskee?
Mitä tapahtui? Valitse alta
Ehdotus: Mielestäni seuraava seikka parantaisi pelin toteutusta huomattavasti
Tarkka kuvaus
• Selitä ehdotuksesti tarkasti ja ytimekkäästi, jotta se on ymmärrettävissä niin helposti kuin mahdollista.
Please, add ID to all elements in the game to make it compatible with BGA tutorial creator, and check for overlapping DIVs. This BGA page explains this in more detail: en.doc.boardgamearena.com/Tutorials_checklist
Specifically:
"If a player trying to create a tutorial reports you an issue about (3):
- you might have some overlapping elements preventing to access the "div" tag of an important interface element to attach tutorial content to it.
- you might have some missing "ID" on elements of the interface, preventing the tutorial author to attach elements to them."• Mikä on selaimesi?
Google Chrome v134
Raportin historia
30. maalis 2025 9:34 • Infi220 • Kehittäjät eivät ole vielä tutkineet tätä ehdotusta:
I think the problem is that these divs don't have an ID:
<div class="um_umbrella bg-umbrella_2" style="position: relative;">
I did an experiment with Chrome dev tools, and when I manually add an ID to this div, then the tutorial works.
<div class="um_umbrella bg-umbrella_2" style="position: relative;">
I did an experiment with Chrome dev tools, and when I manually add an ID to this div, then the tutorial works.
30. maalis 2025 9:52 • Moof • Kehittäjät tahtoisivat lisätietoa tästä ehdotuksesta:
Can you try again please?
30. maalis 2025 19:01 • Infi220 • Kehittäjät tahtoisivat lisätietoa tästä ehdotuksesta:
It works better now but not completely. The ID fix allows me to mark the elements in the tutorial, but it's still impossible to click them and take an action in the replay. You can see my tutorial test here:
boardgamearena.com/archive/replay/250326-1050/?table=651495995&player=97510471&comments=88656919;
BGA explains the likely cause on this page: en.doc.boardgamearena.com/Tutorials_checklist
[Quote]
Each action of the replay should be replayable by triggering it manually (i.e. by reproducing the exact same sequence as done played originally during the game
(...) most likely reasons for the issue are:
- that you have triggered this.ajaxcall() / this.bgaPerformAction() programmatically in a notification handling function or a callback instead of only on a user interface action.
- or that there are several way to trigger the next action with different URL/arguments. You should make sure that the same game actions are triggered with the same "ajaxcall" / "bgaPerformAction" whatever the UX path used.
[/Quote]
boardgamearena.com/archive/replay/250326-1050/?table=651495995&player=97510471&comments=88656919;
BGA explains the likely cause on this page: en.doc.boardgamearena.com/Tutorials_checklist
[Quote]
Each action of the replay should be replayable by triggering it manually (i.e. by reproducing the exact same sequence as done played originally during the game
(...) most likely reasons for the issue are:
- that you have triggered this.ajaxcall() / this.bgaPerformAction() programmatically in a notification handling function or a callback instead of only on a user interface action.
- or that there are several way to trigger the next action with different URL/arguments. You should make sure that the same game actions are triggered with the same "ajaxcall" / "bgaPerformAction" whatever the UX path used.
[/Quote]
30. maalis 2025 19:48 • Moof • Kehittäjät tahtoisivat lisätietoa tästä ehdotuksesta:
I pushed a modification but I can't access your replay, can u check please?
1. huhti 2025 4:35 • Infi220 • Kehittäjät tahtoisivat lisätietoa tästä ehdotuksesta:
I tried again and the problem. So, I looked into the code again and found the issue. There is an if() condition in the following 3 functions in UmBoard.js:
activateCards
activatePoints
activateUmbrellas
That if() looks like this:
if (this.root.isReadOnly()) return;
Since isReadOnly() returns true in a replay, it causes those 3 functions to quit prematurely.
Removing all 3 occurrences of that if() fixes the replay.
activateCards
activatePoints
activateUmbrellas
That if() looks like this:
if (this.root.isReadOnly()) return;
Since isReadOnly() returns true in a replay, it causes those 3 functions to quit prematurely.
Removing all 3 occurrences of that if() fixes the replay.
1. huhti 2025 17:33 • Infi220 • Tämä ehdotus on toteutettu:
Thank you! That issue has been fixed now. There is just one last thing: could you please add IDs to the arrow DIVs that show on the player board after selecting an umbrella? Those DIVs look like this:
<div class="um_arrow bg-arrow_1"></div>
<div class="um_arrow bg-arrow_2"></div>
<div class="um_arrow bg-arrow_3"></div>
<div class="um_arrow bg-arrow_4"></div>
<div class="um_arrow bg-arrow_1"></div>
<div class="um_arrow bg-arrow_2"></div>
<div class="um_arrow bg-arrow_3"></div>
<div class="um_arrow bg-arrow_4"></div>
2. huhti 2025 9:10 • Moof • Tämä ehdotus on toteutettu:
Done.
Note that those div were already encapsulated in other div with id, like I usually do. But now you have both id
Note that those div were already encapsulated in other div with id, like I usually do. But now you have both id
3. huhti 2025 8:01 • Infi220 • Tämä ehdotus on toteutettu:
I tried it just now and those inner divs still don't have an ID. Screenshot: snipboard.io/VtOX74.jpg
I'm aware the outer divs have IDs but the BGA tutorial interface needs the inner divs with IDs too. If it's not much trouble could you please check why your last fix wasn't applied?
I can do a workaround but it won't be as nice as if the IDs were there.
I'm aware the outer divs have IDs but the BGA tutorial interface needs the inner divs with IDs too. If it's not much trouble could you please check why your last fix wasn't applied?
I can do a workaround but it won't be as nice as if the IDs were there.
3. huhti 2025 8:08 • Moof • Tämä ehdotus on toteutettu:
The patch wasnt in production. This should be ok now.
Lisää jotain tähän raporttiin
Lisää tähän mitä tahansa, minkä katsot oleelliseksi tämän bugin toisintamiseksi tai ehdotuksesi ymmärtämiseksi:
- Toinen pöydän tunnus / siirron numero
- Ratkaisiko F5 ongelman?
- Ilmestyykö ongelma useita kertoja? Joka kerta? Satunnaisesti?
- Jos sinulla on kuvankaappaus tästä bugista, voit käyttää Imgur.com:a sen lähettämiseksi. Kopioi ja liitä linkki tähän.
